nick/PlotDirector
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Tighten single-word character candidate filtering

Browse Source
This commit is contained in:
Nick Beckley 2026-08-17 19:33:38 +00:00
parent 95f5c2925d
commit 09f003b0cd
2 changed files with 23 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
PlotLine.Tests/Program.cs
View File

@ -1302,6 +1302,17 @@ static void CharacterDiscoveryRejectsSentenceStartWords()
Assert(candidates.Any(candidate => candidate.Text == "Debbie"), "Real common character names should still be detected."); Assert(candidates.Any(candidate => candidate.Text == "Debbie"), "Real common character names should still be detected.");
Assert(candidates.Any(candidate => candidate.Text == "Mr Wilkinson"), "Titled character names should still be detected."); Assert(candidates.Any(candidate => candidate.Text == "Mr Wilkinson"), "Titled character names should still be detected.");
Assert(!candidates.Any(candidate => candidate.Text is "Silence" or "Morning" or "Eyes"), "Repeated sentence-start words must not become character candidates."); Assert(!candidates.Any(candidate => candidate.Text is "Silence" or "Morning" or "Eyes"), "Repeated sentence-start words must not become character candidates.");
var actionText = """
Door opened before anyone moved. Door closed behind them.
Glass shattered across the floor. Glass glittered under the counter.
Window rattled in the frame. Window shook again.
Colin opened the file. Debbie watched Colin.
""";
var actionCandidates = (IReadOnlyList<WordCompanionCharacterCandidateDto>)method!.Invoke(null, [actionText, false])!;
Assert(actionCandidates.Any(candidate => candidate.Text == "Colin"), "Known character names should still survive action evidence.");
Assert(actionCandidates.Any(candidate => candidate.Text == "Debbie"), "Known character names should still survive action evidence.");
Assert(!actionCandidates.Any(candidate => candidate.Text is "Door" or "Glass" or "Window"), "Repeated sentence-start action nouns must not become character candidates.");
} }
static void StoryIntelligenceExperienceBootDoesNotSerialiseLiveModel() static void StoryIntelligenceExperienceBootDoesNotSerialiseLiveModel()

14
PlotLine/Services/WordCompanionService.cs
View File

@ -744,7 +744,8 @@ public sealed class WordCompanionService(
&& !hasKnownGivenName && !hasKnownGivenName
&& !hasNameLikeWord && !hasNameLikeWord
&& evidence.PossessiveEvidenceCount == 0 && evidence.PossessiveEvidenceCount == 0
&& nonSentenceStartMentions == 0) && evidence.DialogueEvidenceCount == 0
&& nonSentenceStartMentions < 2)
{ {
score -= 5; score -= 5;
} }
@ -819,7 +820,16 @@ public sealed class WordCompanionService(
&& mostlySentenceStart && mostlySentenceStart
&& !hasNameEvidence && !hasNameEvidence
&& evidence.PossessiveEvidenceCount == 0 && evidence.PossessiveEvidenceCount == 0
&& evidence.MentionCount - evidence.SentenceStartMentions == 0) && evidence.DialogueEvidenceCount == 0
&& evidence.MentionCount - evidence.SentenceStartMentions < 2)
{
return "Excluded";
}
if (isSingleWord
&& !hasNameEvidence
&& evidence.DialogueEvidenceCount == 0
&& evidence.PossessiveEvidenceCount == 0
&& evidence.MentionCount - evidence.SentenceStartMentions < 2)
{ {
return "Excluded"; return "Excluded";
} }